Conversation
|
I don't think that this PR is necessary yet. As you pointed out in your comment #2898 (comment) the browsers will actually drop TLS 1.1 support in March 2020. We should then come back and remove TLS below 1.2 for all devices alltogether. |
TobiGr
left a comment
There was a problem hiding this comment.
It is March. We should be good to go. I plan to merge this at the weekend and leave this open until then for potential comments from other contributors.
app/src/main/java/org/schabi/newpipe/util/TLSSocketFactoryCompat.java
Outdated
Show resolved
Hide resolved
|
@TobiGr see #2898 (comment) |
Co-Authored-By: Stypox <stypox@pm.me>
|
while waiting for the next update for Netcipher this PR could be changed in the following way: |
|
Which does not really adress the set ciphersuites, which are also different between android versions. I seriously do not want to touch that, this will have to happen in another PR. |
|
But i agree that waiting for netcipher is not viable. |
679bc75 to
2aeccc0
Compare
|
Converted to draft:
Should be closed in the future if no further progress happens here. |
|
this is superseded by PR #7175 |
partly fixes #2898
I wasn't able to test this yet because I'm not at my usual workstation, the soonest I'll be able to is in ~1 week.